Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #895: Create a new block in Imagify #906

Merged
merged 24 commits into from
Oct 30, 2024

Conversation

jeawhanlee
Copy link
Contributor

@jeawhanlee jeawhanlee commented Oct 11, 2024

Description

Fixes #895
Explain how this code impacts users.

Type of change

  • New feature (non-breaking change which adds functionality).
  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Adds a new block for plugin family in settings page.

Technical description

Documentation

New package created, which is used to get the plugin family data for one click installation & activation.

New dependencies

https://packagist.org/packages/wp-media/plugin-family

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@jeawhanlee jeawhanlee self-assigned this Oct 11, 2024
@jeawhanlee
Copy link
Contributor Author

We have section showing plugins with different state ( Install, Activated & already Activated). Also, the activated plugins comes last in the order.

Screenshot 2024-10-21 at 12 46 26

@jeawhanlee jeawhanlee marked this pull request as ready for review October 21, 2024 14:34
@jeawhanlee jeawhanlee requested a review from a team October 21, 2024 14:34
inc/classes/class-imagify-views.php Outdated Show resolved Hide resolved
views/page-settings.php Outdated Show resolved Hide resolved
@jeawhanlee jeawhanlee requested a review from remyperona October 23, 2024 08:48
@hanna-meda
Copy link

hanna-meda commented Oct 28, 2024

@jeawhanlee, thank you for your work on this. I've noted a few minor fixes below:

  1. Commas needed in 2 places from description & "website" at the end is misspelled.
Screenshot 2024-10-28 at 16 07 24 2. Learn More links should open in new tab. Currently, they open in the same tab.

@jeawhanlee
Copy link
Contributor Author

Thanks @hanna-meda
Wordings has been fixed and Learn more links now open in a new page.

Screenshot 2024-10-28 at 16 36 05

@Miraeld Miraeld requested a review from wordpressfan October 29, 2024 08:12
@piotrbak
Copy link

@jeawhanlee Seems like we're good to go here

@jeawhanlee jeawhanlee added this pull request to the merge queue Oct 30, 2024
Merged via the queue into develop with commit 76ec1bf Oct 30, 2024
5 of 6 checks passed
@jeawhanlee jeawhanlee deleted the enhancement/895-create-a-new-block-in-imagify branch October 30, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a New Block in Imagify
5 participants